Skip to content

[freqtbl-] add commands to delete rows on source sheet#2961

Closed
midichef wants to merge 1 commit intosaulpw:developfrom
midichef:freqtbl_delete_sourcerow
Closed

[freqtbl-] add commands to delete rows on source sheet#2961
midichef wants to merge 1 commit intosaulpw:developfrom
midichef:freqtbl_delete_sourcerow

Conversation

@midichef
Copy link
Copy Markdown
Contributor

@midichef midichef commented Feb 2, 2026

This was a feature request in #2950 by @Ankit-Kulkarni.

For deleting rows I used self.deleteBy(lambda r: self.rowid(r) == rid). Can I replace it with the slightly faster self.deleteBy(lambda r, freqtbl_row=freqtbl_row: r is freqtblq_row)? I'm not sure.

@saulpw
Copy link
Copy Markdown
Owner

saulpw commented Feb 9, 2026

I proposed a workflow in #2950 that has a couple more steps, but doesn't require additional commands or override existing bindings. Do you think we need/want specialized commands to do this?

@Ankit-Kulkarni
Copy link
Copy Markdown

@saulpw as a everyday regular user of vd, I have been using these commands from a few days now and honestly while the other flows still work(i was using the same earlier ) this approach is just blazing fast (i.e less commands to remember and navigate through).

Mentally its just super easy zd and thats it , no inverse selection , no select and delete. The problem with such select flows is that if you end up selecting wrong you will have to undo or carefully unselect , basically chances of having more operations.

Unless adding commands is not an overhead or can create an issue , I really thing having this as default would definitely help.

@midichef

@saulbert
Copy link
Copy Markdown
Collaborator

saulbert commented Mar 6, 2026

Thanks for working on this! The inverse-filter use case from #2950 is a good one.

This has been addressed differently on develop — instead of deletion (which is destructive and has tricky undo semantics from a derived sheet), zEnter and gzEnter on FreqTableSheet now open a copy of the source sheet with all rows except those in the current/selected bins. This mirrors the existing Enter/gEnter pattern and is non-destructive.

Closing in favor of that approach. Thanks again for the motivation!

[this comment written by Claude Opus 4.6 and approved by @saulpw]

@saulpw saulpw closed this Mar 6, 2026
@midichef midichef deleted the freqtbl_delete_sourcerow branch March 7, 2026 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants