Open
Conversation
haininhhoang94
commented
Nov 14, 2025
haininhhoang94
commented
- If contributing a core loader, the loader checklist was referenced.
- If registering an external plugin, the plugin checklist was referenced.
|
Hai Ninh Hoang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Owner
|
Hi @haininhhoang94, I can't see what's changed because of all the formatting changes. Can you remove them, and only include the changes necessary to fix the issue you found? Also it would be great if you would link to the issue you are fixing (use |
Author
|
Sure! I was using visidata and saw no one mention the histogram breaking in 3.13 when press F, so I fast fixing those |
Python's int('42.5') raises ValueError even though int(42.5) works.
This caused CSV-loaded columns (which store strings) to fail when
typed as int if values contained decimal points (e.g. '42.5', '-3.14').
Add _coerceVal() pre-coercion layer in Column that routes str->int
conversions through float first: int(float('42.5')) -> 42.
Applied in both getTypedValue() and setValuesTyped().
…ries Two bugs in PandasSheet: 1. dtype_to_type() was called with df[col] (a Series) instead of df[col].dtype, causing ValueError when np.issubdtype receives a Series with StringDtype. 2. The except clause only caught TypeError, but StringDtype columns raise ValueError from np.issubdtype. Now catches both. 3. Explicitly detect pandas StringDtype and map it to str instead of falling through to anytype.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.