Add parenthesis in operations to keep order. #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamelalozano16
force-pushed
the
calc-interpolation
branch
2 times, most recently
from
228bbbe to
a74a811
Compare
jathak
reviewed
Dec 12, 2023
test/migrators/calc_interpolation/calc_remove_interpolation.hrx
Outdated
Show resolved
Hide resolved
pamelalozano16
force-pushed
the
calc-interpolation
branch
from
a74a811 to
f4022c4
Compare
jathak
approved these changes
Dec 13, 2023
pamelalozano16
force-pushed
the
calc-interpolation
branch
from
f4022c4 to
88e6ace
Compare
pamelalozano16
force-pushed
the
calc-interpolation
branch
from
88e6ace to
8600a76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: Removing interpolation was causing changes in the order of calculations.
Replacing interpolation with parenthesis in these cases produces the same result.
Ex.
$a * #{$b + $c}is not the same calculation as$a * $b + $c, but it is the same as .$a * ($b + $c)