Skip to content

Fix a bug where a double-configuration error wouldn't be emitted #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix a bug where a double-configuration error wouldn't be emitted #2600

wants to merge 1 commit into from
+27 −13

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Jul 3, 2025

@nex3 nex3 requested a review from jathak July 3, 2025 00:01
@arikorn
Copy link

arikorn commented Jul 3, 2025

I am concerned that this PR would break existing codebases (see @nex3's justification for this PR in #2598). It is possible that my PR #2602 would mitigate these effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jathak jathak Awaiting requested review from jathak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] This module was already loaded false positive
2 participants
@nex3 @arikorn