Fix: The root cause of the error is that after throwing#1
Closed
sarthakNITT wants to merge 1 commit intomainfrom
Closed
Fix: The root cause of the error is that after throwing#1sarthakNITT wants to merge 1 commit intomainfrom
sarthakNITT wants to merge 1 commit intomainfrom
Conversation
Fix: The root cause of the error is that after throwing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
The root cause of the error is that after throwing an error inside the 'cause_crash' action block, the code attempts to return a Response object, which is unreachable and redundant. More importantly, the thrown error 'SeededDemoFailure: deterministic bug for AIA demo' is intentionally thrown in the 'cause_error' action block, which is caught by the catch handler. The stacktrace points to line 41, which corresponds to the throw statement of this error. The error is intentionally thrown to simulate a deterministic failure scenario for demo purposes. The root cause is that the error is thrown intentionally and propagated without being handled to prevent the crash, which is expected behavior for this demo scenario.
Fix
Applied patch automatically.