-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adafruit bno055 update + added position configs #124
Open
ronzeiller
wants to merge
22
commits into
sarfata:master
Choose a base branch
from
ronzeiller:adafruit_bno055_update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+179
−77
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
c1c0723
changed cal offsets to signed ints
ronzeiller 735c0b3
Minor cal cleanup (better comments, etc.) Update to V1.1.6
ronzeiller 7b522a1
Update to 1.1.6
ronzeiller e01a593
changed calibrationdata from uint_8 to int
ronzeiller ccb22b8
back to uint16_t for calibrationData[22]
ronzeiller c9febf0
corrected comment
ronzeiller e0a5e21
config: now all horizontal positions, vars changed to lower case letters
ronzeiller 69b2545
added kbox-config.json as individual user's config file
ronzeiller 53b8147
change to more generic wording of mounting positions (KBox+free Sensor)
ronzeiller 89bdb3e
verticalPortHull, verticalStbHull added, heel +/-ve corrected
ronzeiller 9c57dc2
updated comments for IMU-sensor/KBox positioning
ronzeiller 6d2e3e1
Merge remote-tracking branch 'upstream/master' into adafruit_bno055_u…
ronzeiller 2ce4d1d
Color of displayed values now correspond to if values are sent
ronzeiller a96150d
deleted deprecated mounting positions
ronzeiller 702b57d
added individual user's config file
ronzeiller 63b8c44
added [env:teensy3.6]
ronzeiller 4e0d1bf
added BOARD_ronzei (Teensy 3.6 based KBox development prototype)
ronzeiller 4cc5d12
Merge remote-tracking branch 'upstream/master' into adafruit_bno055_u…
ronzeiller 420e11a
Merge remote-tracking branch 'upstream/master' into adafruit_bno055_u…
ronzeiller 1f9dde7
corrected bug in inverting angles
ronzeiller 89028f8
back to uptodate master branch
ronzeiller 5bf933f
doc: changelog for v1.3.7
ronzeiller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,9 @@ | ||
name=Adafruit BNO055 | ||
version=1.0.6 | ||
version=1.1.6 | ||
author=Adafruit <[email protected]> | ||
maintainer=Adafruit <[email protected]> | ||
sentence=Library for the Adafruit BNO055 Absolute Orientation Sensor. | ||
paragraph=Designed specifically to work with the Adafruit BNO055 Breakout, and is based on Adafruit's Unified Sensor Library. | ||
category=Sensors | ||
url=https://github.com/adafruit/Adafruit_BNO055 | ||
architectures=* | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have two options that are the same thing? It looks like
verticalPortHull == verticalRightSideToBow
? Or maybe I am missing something?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes if I remember right, it is the same.
verticalPortHull
is the "deprecated" naming convention which I believe you have in your config. If you switch to the "more detailed naming convention" then we do not need it anymore.If you like it in principle and if it is easy for you to change, please do so.
Otherwise I think the right way is to merge your new commits, add the
[env:host36]
and delete theverticalPortHull
,verticalStbHull
settings in this PR, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new naming and I think it's good to remove the old one to keep the more explicit one. 👍