Don't crash on Linux machines with L4 cache #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently found out that this is a thing when trying to run a
candle
program (which depends ongemm
) on this machine:The Linux-specific code path that probes cache sizes via
lscpu
andsysfs
assumes thatlevel
can't be greater than 3, so without this PR anything usinggemm
crashes like this:This PR fixes this by adding a guard identical to the one existing in the generic X86 cache size probing code.
(an interesting theoretical question is whether it is possible to somehow exploit this gigantic 128 MiB cache instead of ignoring it)