Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard Table #23

Merged
merged 4 commits into from
Apr 26, 2024
Merged

Conversation

joaorodrs
Copy link
Contributor

@joaorodrs joaorodrs commented Sep 12, 2022

Description

Creating one table for each entity is kind of a code duplication issue, and this issue was highlighted by the code inspector the enterprise I'm working in uses. 60% of the code duplications issues came from this tables, mainly because of the stacked duplications of pages, search terms and filters states, that are the same thing for every table.

Closes #24 and #12

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Just used the new "Standard Table" component in the existing users page and tested the listing and manipulation of the items in the table, and seems to work just fine.

Did you test this update on all browsers?

  • Chrome
  • Safari
  • Firefox
  • Edge

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added stories for the new components

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@joaorodrs
Copy link
Contributor Author

  • I have added stories for the new components

Similar #12

Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor Author

@joaorodrs joaorodrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Reviewed XD

@joaorodrs joaorodrs marked this pull request as ready for review March 5, 2024 20:54
@joaorodrs joaorodrs changed the title WIP: Standard Table Standard Table Mar 5, 2024
@santospatrick
Copy link
Owner

@joaorodrs prop endpoint is very helpful! It eliminates one's common workflow to duplicate "UsersTable" into another context, and duplicating again and again... love <StandardTable />!

@santospatrick santospatrick merged commit cf302b3 into santospatrick:main Apr 26, 2024
1 check passed
@joaorodrs joaorodrs deleted the feat/standard-table branch April 27, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table duplication
2 participants