Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core) : merge next into corel (Do not merge, run tests) #8318

Merged
merged 3 commits into from
Jan 17, 2025
Merged

chore(core) : merge next into corel (Do not merge, run tests) #8318

merged 3 commits into from
Jan 17, 2025
+11,711 −131

Conversation

pedrobonamin
Copy link
Contributor

Description

What to review

Testing

Notes for release

@pedrobonamin pedrobonamin requested a review from a team as a code owner January 17, 2025 18:37
@pedrobonamin pedrobonamin requested review from bjoerge and removed request for a team January 17, 2025 18:37
@vercel Vercel
Copy link

vercel bot commented Jan 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 6:45pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 6:45pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 6:45pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Jan 17, 2025 6:45pm
test-next-studio ⬜️ Ignored (Inspect) Jan 17, 2025 6:45pm

@socket-security Socket Security
Copy link

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@sanity/[email protected] 🔁 npm/@sanity/[email protected] None 0 0 B
npm/@sanity/[email protected] 🔁 npm/@sanity/[email protected] None 0 817 kB sanity-io
npm/@sanity/[email protected] None +1 98.6 kB sanity-io
npm/@sanity/[email protected] None +1 81.3 kB sanity-io

🚮 Removed packages: npm/@sanity/[email protected]

View full report↗︎

@pedrobonamin pedrobonamin changed the title corel : Corel merge next Not merge chore(core) : merge next into corel (Do not merge, run tests) Jan 17, 2025
@pedrobonamin pedrobonamin removed the request for review from bjoerge January 17, 2025 18:42
@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

Component Testing Report Updated Jan 17, 2025 6:50 PM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 10s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 19s 5 0 1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 54s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 41s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 4s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 44s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@github-actions GitHub Actions
Copy link
Contributor

⚡️ Editor Performance Report

Updated Fri, 17 Jan 2025 18:50:32 GMT

Benchmark reference
latency of sanity@latest		 experiment
latency of this branch		 Δ (%)
latency difference
article (title) 20.0 efps (50ms) 21.3 efps (47ms) -3ms (-6.0%) ✅
article (body) 59.5 efps (17ms) 63.3 efps (16ms) -1ms (-6.0%) ✅
article (string inside object) 23.3 efps (43ms) 25.6 efps (39ms) -4ms (-9.3%) ✅
article (string inside array) 20.4 efps (49ms) 22.2 efps (45ms) -4ms (-8.2%) ✅
recipe (name) 52.6 efps (19ms) 62.5 efps (16ms) -3ms (-15.8%) ✅
recipe (description) 58.8 efps (17ms) 58.8 efps (17ms) +0ms (-/-%) ✅
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (5ms) -1ms (-/-%) ✅
synthetic (title) 17.9 efps (56ms) 20.0 efps (50ms) -6ms (-10.7%) ✅
synthetic (string inside object) 19.4 efps (52ms) 19.2 efps (52ms) +1ms (+1.0%) ✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 50ms 71ms 99ms 479ms 1168ms 12.5s
article (body) 17ms 22ms 30ms 98ms 279ms 5.8s
article (string inside object) 43ms 45ms 48ms 58ms 49ms 6.9s
article (string inside array) 49ms 53ms 59ms 245ms 626ms 7.9s
recipe (name) 19ms 20ms 22ms 40ms 0ms 6.6s
recipe (description) 17ms 18ms 20ms 28ms 0ms 4.3s
recipe (instructions) 6ms 7ms 8ms 17ms 0ms 3.1s
synthetic (title) 56ms 58ms 63ms 307ms 1134ms 13.2s
synthetic (string inside object) 52ms 56ms 71ms 326ms 778ms 8.6s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 47ms 68ms 91ms 443ms 907ms 11.9s
article (body) 16ms 18ms 20ms 78ms 131ms 5.7s
article (string inside object) 39ms 41ms 44ms 222ms 291ms 7.4s
article (string inside array) 45ms 47ms 59ms 84ms 263ms 7.6s
recipe (name) 16ms 18ms 21ms 43ms 0ms 6.5s
recipe (description) 17ms 18ms 21ms 35ms 2ms 4.8s
recipe (instructions) 5ms 6ms 8ms 9ms 0ms 3.1s
synthetic (title) 50ms 52ms 56ms 270ms 585ms 12.0s
synthetic (string inside object) 52ms 57ms 71ms 290ms 1009ms 8.2s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@pedrobonamin pedrobonamin merged commit b47e306 into corel Jan 17, 2025
53 of 56 checks passed
@pedrobonamin pedrobonamin deleted the corel-merge-next branch January 17, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedrobonamin @stipsan