Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): merge next into corel #8311

Merged
merged 5 commits into from
Jan 17, 2025
Merged

chore(core): merge next into corel #8311

merged 5 commits into from
Jan 17, 2025

Conversation

pedrobonamin
Copy link
Contributor

Description

Do not merge

What to review

Testing

Notes for release

ecospark bot and others added 4 commits January 16, 2025 18:17
Co-authored-by: ecospark[bot] <128108030+ecospark[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@pedrobonamin pedrobonamin requested a review from a team as a code owner January 17, 2025 10:25
@pedrobonamin pedrobonamin requested review from rexxars and removed request for a team January 17, 2025 10:25
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 10:51am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 10:51am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 10:51am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 10:51am
test-next-studio ⬜️ Ignored (Inspect) Jan 17, 2025 10:51am

@pedrobonamin pedrobonamin removed the request for review from rexxars January 17, 2025 10:25
Copy link

socket-security bot commented Jan 17, 2025

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@sanity/[email protected] 🔁 npm/@sanity/[email protected] None 0 0 B

View full report↗︎

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Jan 17, 2025 10:55 AM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 3s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 19s 5 0 1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 6s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 34s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 6s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 47s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Fri, 17 Jan 2025 10:56:07 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 24.7 efps (41ms) 26.7 efps (38ms) -3ms (-7.4%)
article (body) 72.7 efps (14ms) 63.5 efps (16ms) +2ms (-/-%)
article (string inside object) 26.3 efps (38ms) 28.2 efps (36ms) -3ms (-6.6%)
article (string inside array) 24.4 efps (41ms) 26.3 efps (38ms) -3ms (-7.3%)
recipe (name) 52.6 efps (19ms) 62.5 efps (16ms) -3ms (-15.8%)
recipe (description) 58.8 efps (17ms) 66.7 efps (15ms) -2ms (-11.8%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 17.1 efps (59ms) 19.6 efps (51ms) -8ms (-12.8%)
synthetic (string inside object) 18.5 efps (54ms) 19.2 efps (52ms) -2ms (-3.7%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 41ms 49ms 65ms 191ms 829ms 10.5s
article (body) 14ms 15ms 16ms 164ms 217ms 5.2s
article (string inside object) 38ms 41ms 51ms 95ms 252ms 6.9s
article (string inside array) 41ms 43ms 47ms 170ms 184ms 6.8s
recipe (name) 19ms 21ms 25ms 40ms 0ms 6.9s
recipe (description) 17ms 18ms 20ms 28ms 0ms 4.3s
recipe (instructions) 5ms 7ms 8ms 10ms 0ms 3.0s
synthetic (title) 59ms 61ms 65ms 356ms 772ms 15.5s
synthetic (string inside object) 54ms 56ms 65ms 271ms 743ms 8.6s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 38ms 63ms 68ms 486ms 986ms 11.1s
article (body) 16ms 19ms 21ms 137ms 74ms 5.3s
article (string inside object) 36ms 39ms 49ms 231ms 370ms 7.0s
article (string inside array) 38ms 40ms 44ms 86ms 139ms 6.6s
recipe (name) 16ms 18ms 20ms 41ms 0ms 7.1s
recipe (description) 15ms 16ms 17ms 27ms 0ms 4.3s
recipe (instructions) 5ms 6ms 7ms 10ms 0ms 3.0s
synthetic (title) 51ms 55ms 62ms 121ms 440ms 13.1s
synthetic (string inside object) 52ms 56ms 66ms 510ms 1446ms 8.9s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@pedrobonamin pedrobonamin merged commit 1501203 into corel Jan 17, 2025
53 of 55 checks passed
@pedrobonamin pedrobonamin deleted the corel-merge-next branch January 17, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants