Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): switch to actions/download-artifact@v4 #8300

Closed
wants to merge 2 commits into from

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Jan 16, 2025

Description

Switches to v4 since v3 is deprecated and fails CI

What to review

Does CI pass?

Testing

we're good if CI is passing

Notes for release

n/a - internal

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 4:16pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 4:16pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 4:16pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 4:16pm
test-next-studio ⬜️ Ignored (Inspect) Jan 16, 2025 4:16pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Jan 16, 2025 4:22 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 21s 7 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 31s 7 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 3s 1 3 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 6s 2 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 25s 7 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 1 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 1 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Thu, 16 Jan 2025 16:24:37 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
recipe (name) 47.6 efps (21ms) 47.6 efps (21ms) +0ms (-/-%)
recipe (description) 52.6 efps (19ms) 52.6 efps (19ms) +0ms (-/-%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) -0ms (-/-%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
recipe (name) 21ms 23ms 26ms 42ms 0ms 6.9s
recipe (description) 19ms 21ms 22ms 40ms 1ms 4.7s
recipe (instructions) 6ms 8ms 9ms 20ms 0ms 3.2s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
recipe (name) 21ms 23ms 27ms 38ms 0ms 7.1s
recipe (description) 19ms 20ms 21ms 37ms 0ms 4.8s
recipe (instructions) 6ms 7ms 8ms 9ms 0ms 3.1s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@bjoerge
Copy link
Member Author

bjoerge commented Jan 17, 2025

Fixed by #8298

@bjoerge bjoerge closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant