fix(structure): only reset history params if needed (#8284)

sanity-io · Jan 16, 2025 · d52c0ac · d52c0ac
1 parent 5a98259
commit d52c0ac
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/packages/sanity/src/core/field/diff/contexts/DocumentChangeContext.tsx b/packages/sanity/src/core/field/diff/contexts/DocumentChangeContext.tsx
@@ -8,9 +8,6 @@ export type DocumentChangeContextInstance = {
   documentId: string
   schemaType: SchemaType
   rootDiff: ObjectDiff | null
-  /**
-   * This decides if the diff shows the reverting changes button or not.
-   */
   isComparingCurrent: boolean
   FieldWrapper: ComponentType<{path: Path; children: ReactNode; hasHover: boolean}>
   value: Partial<SanityDocument>

diff --git a/packages/sanity/src/structure/panes/document/useResetHistoryParams.ts b/packages/sanity/src/structure/panes/document/useResetHistoryParams.ts
@@ -16,6 +16,11 @@ export function useResetHistoryParams() {
   const isMounted = useRef(false)
 
   const updateHistoryParams = useEffectEvent((_perspective?: string) => {
+    // Check if any of the history related params are set, and reset them, don't unnecessarily update the params
+    const PARAMS_TO_UPDATE = ['since', 'historyVersion', 'rev', 'preserveRev']
+    const shouldUpdateParams = PARAMS_TO_UPDATE.some((param) => params[param])
+    if (!shouldUpdateParams) return
+
     setParams({
       ...params,
       // Reset the history related params when the perspective changes, as they don't make sense