Skip to content

Fix Decomposer usage in comparison #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zapek wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Decomposer usage in comparison #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/java/com/sangupta/bloomfilter/AbstractBloomFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
import java.io.Closeable;
import java.io.IOException;
import java.nio.charset.Charset;
import java.nio.charset.IllegalCharsetNameException;
import java.nio.charset.UnsupportedCharsetException;
import java.util.Collection;

import com.sangupta.bloomfilter.core.BitArray;
Expand Down Expand Up @@ -391,8 +393,8 @@ public boolean contains(T value) {
if(value == null) {
return false;
}
return contains(value.toString().getBytes(this.currentCharset));

return contains(decomposedValue(value));
}

/**
Expand Down
24 changes: 24 additions & 0 deletions src/test/java/com/sangupta/bloomfilter/TestBloomFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,15 @@

package com.sangupta.bloomfilter;

import java.nio.charset.Charset;
import java.util.ArrayList;
import java.util.List;
import java.util.UUID;

import com.sangupta.bloomfilter.core.BitArray;
import com.sangupta.bloomfilter.core.JavaBitSetArray;
import com.sangupta.bloomfilter.decompose.ByteSink;
import com.sangupta.bloomfilter.decompose.Decomposer;
import junit.framework.Assert;

import org.junit.Test;
Expand Down Expand Up @@ -99,4 +104,23 @@ public void testDefaultFilter() {
System.out.println("False positives found in two millions: " + fpp);
}

@Test
public void testDelegatesFilter() {
String input = "hello";

BloomFilter<String> filter = new AbstractBloomFilter<String>(10 * MAX, FPP, new Decomposer<String>() {
@Override
public void decompose(String object, ByteSink sink) {
sink.putBytes(new StringBuilder(object).reverse().toString().getBytes(Charset.defaultCharset()));
}
}) {

@Override
protected BitArray createBitArray(int numBits) {
return new JavaBitSetArray(numBits);
}
};
filter.add(input);
Assert.assertTrue(filter.contains(input));
}
}