fix: notify Go when SCStream stops unexpectedly and auto-restart speaker source#5
Merged
Merged
Conversation
…ker source When macOS stops the ScreenCaptureKit stream (screen lock, display change, system error), didStopWithError: was only logging — the Go channel stayed open but received no data, causing silent hang and the menu-bar indicator to disappear. Changes: - speaker_darwin.m: call tacitSpeakerStoppedCallback from didStopWithError: when the stream is not already in a deliberate-stop path (self.stopped) - speaker_darwin.h: declare tacitSpeakerStoppedCallback - speaker_darwin.go: replace bare chan[]int16 cgo handle with speakerChan (data channel + sync.Once + self-referencing handle) so both the unexpected-stop callback and the ctx.Done() goroutine can safely close the channel exactly once; add tacitSpeakerStoppedCallback export - pipeline.go: split runSource into runSource (retry loop) + runSourceOnce so that an unexpected stream closure triggers automatic restart after 5s instead of silently stopping the pipeline https://claude.ai/code/session_01LRhvpcLHSUZT1fz9XvbPny
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When macOS stops the ScreenCaptureKit stream (screen lock, display change,
system error), didStopWithError: was only logging — the Go channel stayed
open but received no data, causing silent hang and the menu-bar indicator
to disappear.
Changes:
when the stream is not already in a deliberate-stop path (self.stopped)
(data channel + sync.Once + self-referencing handle) so both the
unexpected-stop callback and the ctx.Done() goroutine can safely close
the channel exactly once; add tacitSpeakerStoppedCallback export
so that an unexpected stream closure triggers automatic restart after 5s
instead of silently stopping the pipeline
https://claude.ai/code/session_01LRhvpcLHSUZT1fz9XvbPny