Conversation
khelwood
requested changes
May 14, 2026
| return isVisiumLpCytAssistHdLabware(labwareType[0] as unknown as string) | ||
| ? Yup.string() | ||
| .required('Required field') | ||
| .matches(/[A-Z0-9]{2}-[A-Z0-9]{7}/, 'Invalid format for a labware type of VISIUM_LP_CYTASSIST_HD') |
Contributor
There was a problem hiding this comment.
This error message probably isn't quite right since it specifically says VISIUM_LP_CYTASSIST_HD
khelwood
approved these changes
May 14, 2026
Contributor
|
@sabrine33 Looks like test failures probably related to this change. https://github.com/sanger/stan-client/actions/runs/25854138074/job/75967623739?pr=1198#step:6:1321 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version