Conversation
Fixes Permission Error when writing to a 666 /dev/null.
DISPLAY=:0 RW_BIND=/tmp/.X11-unix/X0 ./sandbox-run4
2523e48 to
281d5c3
Compare
|
I just stumbled across sandbox-run and it looks quite useful! Of course, running random scripts off GitHub can be as much a problem as running The implementation in this PR makes for a different first impression. It's still very good for shell code, backed by rigorous application of shellcheck and a test suite. I just can't help but ask: what did bubblewrap do wrong that made you decide you'd rather maintain hundreds of lines of shell script? |
8923c51 to
ad9c6a9
Compare
|
@keturn Hey! Thanks for the kind words. Indeed, the recent proliferation of installation steps comprising Then somebody hinted at Considering the two versions functionally equivalent (a huge assumption as I'm a real kernel noob), I now like this one somewhat better. But you too are right, as the length and ordering of the commit log in this PR confirms, shell certainly is full of biting gremlins. I thought of putting the old version in a branch/tag, but your unexpected comment raises legitimate questions whether the two versions can be maintained side by side ...
Would appreciate a more thorough review! 😝 * New additional features in this PR:
|
395b1e6 to
247c5de
Compare
* Use ready/exit fd-s * Keep API socket _outside_ the sandbox
…t dupe on rbind" This reverts commit edc74c7. The reason is it broke tests/test_symlinks.sh. 🤷
... so its sub-mounts (e.g. $ROOT/dev) don't dupe on rbind Refs: edc74c7 (and its reversal ...) Refs: 28a961544088201336d4a5550ad0ad6b648e92a2
The spec on `set -e` reads: > When this option is on, when any command fails ..., > the shell immediately shall exit ..., with the following exceptions: > 1. ... > 2. The **-e setting shall be ignored** when executing the compound > list following the while, ..., a pipeline **beginning with the > ! reserved word**, or any command of an AND-OR list > other than the last. > 3. If the exit status of a compound command > other than a subshell command was the result of a failure while > -e was being ignored, then -e shall not apply to this command.
It can be a security issue. Also not permitted on CI.
|
@keturn Many software packages, aforementioned included, spend that much on build configuration alone. Whereas this one is supposed to work out of the box. Again sincere thanks for the early feedback. Obviously, you're free to use any sandboxing tool that you grasp and trust. |
Reimplementation based on
unsharefromutil-linuxpackage. Dropsbwrapas a dependency.