Skip to content

Fix package build#130

Open
moseschmiedel wants to merge 5 commits into
upgrade-mojo-0.26.3-nightlyfrom
fix-package-build
Open

Fix package build#130
moseschmiedel wants to merge 5 commits into
upgrade-mojo-0.26.3-nightlyfrom
fix-package-build

Conversation

@moseschmiedel
Copy link
Copy Markdown
Collaborator

Move recipe.yaml to the canonical place and use rattler-build with the pixi-build feature so that we can use Larecs🌲 as a git dependency in pixi.toml.

@moseschmiedel moseschmiedel changed the base branch from main to upgrade-mojo-0.26.3-nightly May 12, 2026 13:28
@moseschmiedel moseschmiedel requested review from Copilot and samufi and removed request for Copilot May 12, 2026 13:28
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Pixi-based packaging setup so the project can be consumed as a pixi.toml git dependency, using pixi-build / rattler-build with a canonical conda.recipe/recipe.yaml recipe location.

Changes:

  • Bump workspace version to 0.5.0 and enable pixi-build with the pixi-build-rattler-build backend in pixi.toml.
  • Update the conda recipe to build/install a Mojo package and adjust test execution and dependencies.
  • Regenerate scripts/pixi.lock to the newer lockfile format/version.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
scripts/pixi.lock Updates the scripts environment lockfile to v7 format and reorders/expands locked dependencies.
pixi.toml Enables pixi-build preview and configures the rattler-build backend + recipe path; bumps version to 0.5.0.
conda.recipe/recipe.yaml Moves/updates recipe for rattler-build, switches requirements to mojo-compiler, and changes test invocation/files.
Comments suppressed due to low confidence (4)

conda.recipe/recipe.yaml:30

  • tests runs scripts/run-tests.sh, but the repo script is named scripts/run_tests.sh (underscore). This will make the conda test phase fail with "file not found"; update the path to the correct script name (or rename the script consistently).
    conda.recipe/recipe.yaml:33
  • The test script being invoked (scripts/run_tests.sh) calls pixi run ..., but pixi is not listed in the test requirements.run. Unless the build environment provides pixi implicitly, tests will fail; either add pixi (or the appropriate pixi CLI package) to test requirements or change the script to invoke mojo directly.
    conda.recipe/recipe.yaml:37
  • scripts/run_tests.sh runs mojo ... -I src, but tests.files.source does not include src/. If files.source controls what is available during the conda test phase, this will break imports; include src/ here or adjust the test invocation to rely on the installed package instead of source paths.
    conda.recipe/recipe.yaml:10
  • The recipe source is pinned to a specific git rev. If the goal is to build Larecs as a git dependency at arbitrary refs, this will always build that pinned commit instead of the checked-out dependency revision. Consider using a local path source (or omitting source if the backend injects it) so the built artifact matches the requested git ref/version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@moseschmiedel moseschmiedel self-assigned this May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants