Fix package build#130
Open
moseschmiedel wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Pixi-based packaging setup so the project can be consumed as a pixi.toml git dependency, using pixi-build / rattler-build with a canonical conda.recipe/recipe.yaml recipe location.
Changes:
- Bump workspace version to
0.5.0and enablepixi-buildwith thepixi-build-rattler-buildbackend inpixi.toml. - Update the conda recipe to build/install a Mojo package and adjust test execution and dependencies.
- Regenerate
scripts/pixi.lockto the newer lockfile format/version.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/pixi.lock | Updates the scripts environment lockfile to v7 format and reorders/expands locked dependencies. |
| pixi.toml | Enables pixi-build preview and configures the rattler-build backend + recipe path; bumps version to 0.5.0. |
| conda.recipe/recipe.yaml | Moves/updates recipe for rattler-build, switches requirements to mojo-compiler, and changes test invocation/files. |
Comments suppressed due to low confidence (4)
conda.recipe/recipe.yaml:30
testsrunsscripts/run-tests.sh, but the repo script is namedscripts/run_tests.sh(underscore). This will make the conda test phase fail with "file not found"; update the path to the correct script name (or rename the script consistently).
conda.recipe/recipe.yaml:33- The test script being invoked (
scripts/run_tests.sh) callspixi run ..., butpixiis not listed in the testrequirements.run. Unless the build environment providespixiimplicitly, tests will fail; either addpixi(or the appropriate pixi CLI package) to test requirements or change the script to invokemojodirectly.
conda.recipe/recipe.yaml:37 scripts/run_tests.shrunsmojo ... -I src, buttests.files.sourcedoes not includesrc/. Iffiles.sourcecontrols what is available during the conda test phase, this will break imports; includesrc/here or adjust the test invocation to rely on the installed package instead of source paths.
conda.recipe/recipe.yaml:10- The recipe
sourceis pinned to a specific gitrev. If the goal is to build Larecs as a git dependency at arbitrary refs, this will always build that pinned commit instead of the checked-out dependency revision. Consider using a localpathsource (or omittingsourceif the backend injects it) so the built artifact matches the requested git ref/version.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
recipe.yamlto the canonical place and userattler-buildwith thepixi-buildfeature so that we can use Larecs🌲 as a git dependency inpixi.toml.