Restore ReferenceSequenceFileFactory deleted in previous commit.#1743
Merged
lbergelson merged 2 commits intomasterfrom Apr 22, 2025
Merged
Restore ReferenceSequenceFileFactory deleted in previous commit.#1743lbergelson merged 2 commits intomasterfrom
lbergelson merged 2 commits intomasterfrom
Conversation
cmnbroad
commented
Apr 14, 2025
| return new FastaSequenceFile(path, truncateNamesAtWhitespace); | ||
| } | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Maybe this can just delegate to the new method.
Collaborator
Author
There was a problem hiding this comment.
Fixed. Well, I restored the old method and changed the new one to delegate to the old one.
lbergelson
approved these changes
Apr 22, 2025
Member
lbergelson
left a comment
lbergelson
left a comment
There was a problem hiding this comment.
Thanks, this looks good. It's a bit strange that only the 4 argument version supports bundles, but we can change that if we want to later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.