Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pull_request_check #8

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RadovanTomik
Copy link

A new workflow for additional checks

A new workflow for additional checks
@RadovanTomik RadovanTomik requested a review from torbrenner August 1, 2022 14:02
steps:
- uses: actions/checkout@v2

- name: Setup Java
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the setup Java needed for the actions to run? From a first glance on both actions i would have thought they run independent from a java runtime.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you are right it is not necessary

run: echo ${{ steps.actions_project_version_check.outputs.version }}

- name: Run Changelog CI
uses: saadmk11/[email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we need to enforce some kind of pull request syntax for the changelog generation to work?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regex that verifies the Pull request name is configurable, same as the change log format. What would be your preference regarding both?

@@ -0,0 +1,30 @@
name: Checking pom.xml version and updating changelog

on:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'am unsure if this will work as expected. In the other workflows i use the trigger "on workflow-call", that says that this workflow will be called by other github workflows in our repositories.
Currently that would happen then running a workflow added by the repository creator by using on of the templates in samply/.github.
But that workflow would be really nice to run on all of our repositories. Do you know some way to automatically enforce it for all repositories?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I don't think that all repositories would require this. Currently the action support version checking in pom.xml, packacke.json and text file. We could create a template?

@lablans lablans changed the base branch from develop to main May 25, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants