dnpm: Secure endpoints for ETL and p2p communications #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Threated
requested changes
Dec 18, 2024
Comment on lines
+79
to
+81
| - "traefik.http.routers.dnpm-backend.rule=PathPrefix(`/api`)" | ||
| - "traefik.http.routers.dnpm-backend.tls=true" | ||
| - "traefik.http.routers.dnpm-backend.service=dnpm-backend" |
There was a problem hiding this comment.
Do we even need this router anymore I think the other 2 cover all the relevant cases?
There was a problem hiding this comment.
I think we still need this for the frontend to access the data.
YtvwlD
force-pushed
the
dnpm-dip-secure-endpoints
branch
from
ccd4642 to
28ffdc1
Compare
Threated
approved these changes
Jan 21, 2025
|
Thanks a lot for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one half of the changes we talked about last week: Securing the ETL endpoints with basic auth and denying access to the p2p api for external hosts.
I did not test that the variable actually gets inserted, I'm a bit confused about the shell scripts. But replacing
${ETL_PASSWD}with the actual auth data works.For ETL to work, this needs an ETL processor with support for basic auth. This has been merged, but is not yet part of any release.
@Threated