Add query-params Validation
#2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderkiel
requested changes
Sep 13, 2024
allentiak
force-pushed
the
date-validation
branch
3 times, most recently
from
48d71c5 to
e73caa3
Compare
allentiak
force-pushed
the
date-validation
branch
3 times, most recently
from
c50e9f2 to
8bdb368
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2043 +/- ##
=======================================
Coverage 94.98% 94.99%
=======================================
Files 330 330
Lines 20136 20155 +19
Branches 483 482 -1
=======================================
+ Hits 19126 19146 +20
Misses 527 527
+ Partials 483 482 -1 |
allentiak
force-pushed
the
date-validation
branch
from
8bdb368 to
e5b4e7b
Compare
Before this change, the `query-params` value was coerced, but never validated (which was a bug). * `get-param-value` - add parameter: `validator` (optional) - refactor - document * implement and use validators: - `validate-date` - `validate-string` - `validate-noop` * implement and use coercer: - `coercer-noop` *rename `coerce-report-type` to `coerce-and-validate-report-type`. * implement and use anomalies: - create `invalid-string-param-anom` - create `invalid-date-param-anom` * create `invalid-string-param-msg` (`invalid-date-param-msg` already existed) * add regression test Misc: * document `handler` * add regression test * reformat with `cljfmt`
allentiak
force-pushed
the
date-validation
branch
from
e5b4e7b to
391091c
Compare
alexanderkiel
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.