Refactoring

sammycage · Sep 19, 2024 · 91f5454 · 91f5454
1 parent 10d9401
commit 91f5454
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/source/lunasvg.cpp b/source/lunasvg.cpp
@@ -253,9 +253,9 @@ bool Element::hasAttribute(const std::string& name) const
 
 const std::string& Element::getAttribute(const std::string& name) const
 {
-    if(m_element == nullptr)
-        return emptyString;
-    return m_element->getAttribute(name);
+    if(m_element)
+        return m_element->getAttribute(name);
+    return emptyString;
 }
 
 void Element::setAttribute(const std::string& name, const std::string& value)

diff --git a/source/svgelement.cpp b/source/svgelement.cpp
@@ -17,7 +17,7 @@ SVGRootElement* SVGNode::rootElement() const
 
 ElementID elementid(const std::string_view& name)
 {
-    const struct {
+    static const struct {
         std::string_view name;
         ElementID value;
     } table[] = {

diff --git a/source/svgproperty.cpp b/source/svgproperty.cpp
@@ -8,7 +8,7 @@ namespace lunasvg {
 
 PropertyID propertyid(const std::string_view& name)
 {
-    const struct {
+    static const struct {
         std::string_view name;
         PropertyID value;
     } table[] = {
@@ -68,7 +68,7 @@ PropertyID propertyid(const std::string_view& name)
 
 PropertyID csspropertyid(const std::string_view& name)
 {
-    const struct {
+    static const struct {
         std::string_view name;
         PropertyID value;
     } table[] = {