Update dependencies, run tests on Python 3.11/12#9
Open
lkubb wants to merge 5 commits intosaltstack:masterfrom
Open
Update dependencies, run tests on Python 3.11/12#9lkubb wants to merge 5 commits intosaltstack:masterfrom
lkubb wants to merge 5 commits intosaltstack:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pip-toolsto6.14(last version to support Python 3.7) andpipto23.3.1(latest one, for 3.12).3.11and3.12, drops3.5and3.6from compile target tests (3.6 still works though, 3.5 fails now because the specifiedbackports.zoneinfoversion is not available).--no-headertopip-compilesince this header now includes the Python version it was compiled with (the actual one, not the overridden one). This might be unwanted, not sure.attrsusage todataclasses.Please excuse me submitting this out of the blue. For context, I investigated possible updates to the
salt-extensiontemplates yesterday and got a bit hung up with the requirements specifics. It seems since the creation ofsetuptools-declarative-requirements,setuptoolshas learned to read requirements files viasetup.cfg/pyproject.toml(v62.6), so haspip-compile(v6.1.0).This should tackle the first step in deprecating the usage of
setuptools-declarative-requirements, the next one would be for this tool to learn how to request extras frompip-compileand to make it aware of the files specified inpyproject.toml(if any are, otherwise just pass through the requested extra). That's beyond my understanding of the templating needs and my current time budget though.If unwanted, I hope this at least saves you some time in the future. :)
(I have not updated the
poetry.lockfile since I'm not sure whether I should do this in my own environment).