iam: getInlinePolicyDetails API(GCP) #163
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (70.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
============================================
- Coverage 83.60% 83.58% -0.02%
- Complexity 90 93 +3
============================================
Files 150 150
Lines 8087 8092 +5
Branches 944 946 +2
============================================
+ Hits 6761 6764 +3
- Misses 877 878 +1
- Partials 449 450 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| * | ||
| * @param identityName the name of the identity | ||
| * @param policyName the name of the policy | ||
| * @param policyName the name of the policy. This parameter is optional and subject to cloud semantics. |
There was a problem hiding this comment.
Do we need to update our AwsIam for this function signature change?
There was a problem hiding this comment.
There is no AwsIam as of now, but yes when it's created this should be the signature.
| * @return the policy document details as a string | ||
| */ | ||
| public String getInlinePolicyDetails(String identityName, String policyName, String tenantId, String region) { | ||
| public String getInlinePolicyDetails(String identityName, String policyName, String roleName, String tenantId, String region) { |
There was a problem hiding this comment.
What's the reason for adding this roleName? Is it for aws and ali?
There was a problem hiding this comment.
It is for GCP. GCP APIs need roleName and AWS APIs need tenantId.
3 participants
Summary
< Provide a brief description of the changes in this PR >
Some conventions to follow
docstore:for document store module,blobstorefor Blob Store moduletest:perf: