Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

[Dimonina] make combineQueries strongly typed#733

Open
Dimonina wants to merge 1 commit intosalesforce:masterfrom
Dimonina:feature/combine-queries-strongly-typed
Open

[Dimonina] make combineQueries strongly typed#733
Dimonina wants to merge 1 commit intosalesforce:masterfrom
Dimonina:feature/combine-queries-strongly-typed

Conversation

@Dimonina
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

combineQueries method is not providing types down to the pipe as combineLatest does

What is the new behavior?

combineQueries now copies a signature of combineLatest method with the ability for typescript to calculate types down to the pipe

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Dimonina Dimonina changed the title combineQueries is not strongly typed [Dimonina] make combineQueries strongly typed Aug 18, 2021
@NetanelBasal
Copy link
Collaborator

Can you show an example, please? It seems to have worked.

@tony
Copy link
Contributor

tony commented Jun 11, 2022

@Dimonina Can you rebase and provide some examples?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants