Skip to content

Conversation

@sluongng
Copy link
Contributor

@sluongng sluongng commented Apr 29, 2025

Ignore home and system bazelrc files.
Switch from a pre-release version to the last green release.

Add a protective if-clause in case the non_deprecated_watchfs hack
was empty.

Fixes #10

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @sluongng to sign the Salesforce Inc. Contributor License Agreement.

@sluongng
Copy link
Contributor Author

image
image

Some weird bug with your CLA workflows?

@vogelsgesang
Copy link
Contributor

Some weird bug with your CLA workflows?

No idea what that was. But it seems to have fixed itself, after I published my review comments above. Apparently, that gave our workflows the necessary nudge 🙂

@vogelsgesang
Copy link
Contributor

oh, and the Ubuntu test failed, because the linter doesn't like your code formatting.

error: length comparison to zero
   --> build.rs:139:8
    |
[13](https://github.com/salesforce-misc/bazelrc-lsp/actions/runs/14726206601/job/41389998881?pr=11#step:5:14)9 |     if non_deprecated_watchfs.len() > 0 {
    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!non_deprecated_watchfs.is_empty()`

You can run

cargo fmt --all -- --check
cargo clippy -- -D warnings

locally to verify your changes

Ignore home and system bazelrc files.
Switch from a pre-release version to the last green release.

Add a protective if-clause in case the non_deprecated_watchfs hack
was empty.
@sluongng sluongng requested a review from vogelsgesang April 30, 2025 09:01
@vogelsgesang vogelsgesang merged commit a6fcb98 into salesforce-misc:main Apr 30, 2025
7 checks passed
@vogelsgesang
Copy link
Contributor

Thanks for the contribution. @sluongng!

Out of curiosity: Why are you building this extension from source?
At least as an end user, you should be able to use the pre-built binaries from the Github releases.

Are you planning to contribute additional features, and that's why you are building from source?
Or are there any pre-built binaries missing, so you were forced to build from source?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build.rs picked up homerc

2 participants