Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple clocks with different time zones #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hootanht
Copy link

Fixes #32

Add support for multiple clocks with different time zones.

  • src/clock/app.clock.tsx
    • Update to support multiple clocks with different time zones.
    • Modify the useEffect hook to handle multiple clocks.
    • Add a new state to manage multiple clocks.
  • src/setting/pages/clock/clock.setting.tsx
    • Update to allow setting multiple time zones for the clocks.
    • Modify the useEffect hook to handle multiple time zones.
    • Add a new state to manage multiple time zones.
    • Add a button to add new clocks.
  • electron/main.ts
    • Update to initialize multiple clock windows.
    • Modify the onAppReady function to handle multiple clocks.
    • Add a new function to create multiple clock windows.
  • electron/store.ts
    • Update to define settings for multiple clock widgets.
    • Modify the ClockSettingStore interface to handle multiple clocks.
    • Add a new state to manage multiple clock settings.

Fixes sajjadmrx#32

Add support for multiple clocks with different time zones.

* **src/clock/app.clock.tsx**
  - Update to support multiple clocks with different time zones.
  - Modify the `useEffect` hook to handle multiple clocks.
  - Add a new state to manage multiple clocks.
* **src/setting/pages/clock/clock.setting.tsx**
  - Update to allow setting multiple time zones for the clocks.
  - Modify the `useEffect` hook to handle multiple time zones.
  - Add a new state to manage multiple time zones.
  - Add a button to add new clocks.
* **electron/main.ts**
  - Update to initialize multiple clock windows.
  - Modify the `onAppReady` function to handle multiple clocks.
  - Add a new function to create multiple clock windows.
* **electron/store.ts**
  - Update to define settings for multiple clock widgets.
  - Modify the `ClockSettingStore` interface to handle multiple clocks.
  - Add a new state to manage multiple clock settings.
@sajjadmrx
Copy link
Owner

image

thanks for taking the time. but adding multiple time zones like this isn't a good idea. It will likely introduce many bugs into the application. A better approach would be to ask the user to select multiple time zones by default and provide templates that support multiple time zones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

افزودن ساعت با تایم زون مختلف
2 participants