Merged
Conversation
Contributor
Author
|
To cite @direc85 in rubdos#1, the remaining issue can be resolved in the spec file:
|
Contributor
|
I'm afraid my patch has a few extra lines that should be removed. I'm afk currently, but I'll check and fix that late this evening. |
rainemak
reviewed
Mar 14, 2024
Member
rainemak
left a comment
rainemak
left a comment
There was a problem hiding this comment.
Minor remarks. Looks good and we got Gecko esr78 building against newer Rust as well. We'll do final verification still.
This patch is needed because in sb2 the temp files written to /tmp by rustc are no longer available when the linker tries to use them. Work around the issue by setting $TMPDIR to $HOME/.tmp instead. If $TMPDIR is already set, that value is used as expected.
mlehtima
approved these changes
Mar 15, 2024
rainemak
approved these changes
Mar 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #21, but doesn't compile at all yet.
Plan:
It would be highly beneficial for Whisperfish to have 1.75, because I expect the Rust ecosystem to adapt the return position
impl Traitin trait feature very rapidly.Part of The Rust Plan