Bug Fix: Correctly Support > [!IMPORTANT]
s and > [!CAUTION]
s in Admonitions
#645
+5
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Checklist
Related Issue
It is said that fuwari supports both markdown directives and the github syntax like
> [!IMPORTANT]
for admonition cards. However, for the github syntax, only> [!NOTE]
,> [!TIP]
and> [!WARNING]
function correctly and> [!IMPORTANT]
and> [!CAUTION]
do not.This is because the
remarkGithubAdmonitionsToDirectives
used to support the github syntax generates:::info
s and:::danger
s, while fuwari expect that to be:::important
s and:::caution
s to render the admonitions.Changes
Edit the config to adapt to the markdown directives generated by the
remarkGithubAdmonitionsToDirectives
.How To Test
Write an
> [!IMPORTANT]
to any post.For example, my post:
Before
After
Screenshots (if applicable)
Additional Notes