Skip to content

frontend/flyout/terminal: get rid of deprecated ReactDOM.findDOMNode #7977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2024
Merged

frontend/flyout/terminal: get rid of deprecated ReactDOM.findDOMNode #7977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions src/packages/frontend/project/page/flyouts/files-terminal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { debounce } from "lodash";

import {
CSS,
ReactDOM,
redux,
useActions,
useEffect,
Expand Down Expand Up @@ -61,7 +60,7 @@ export function TerminalFlyout({
const account_id = useTypedRedux("account", "account_id");
const terminal = useTypedRedux("account", "terminal");
const terminalRef = useRef<Terminal | undefined>(undefined);
const terminalDOMRef = useRef<any>(null);
const terminalDOMRef = useRef<HTMLDivElement>(null);
const isMountedRef = useIsMountedRef();
const student_project_functionality =
useStudentProjectFunctionality(project_id);
Expand Down Expand Up @@ -89,13 +88,11 @@ export function TerminalFlyout({
const id = `flyout::${hash}`; // TODO what exactly is the ID? arbitrary or a path?
useEffect(() => {
if (compute_server_id) {
redux
.getProjectActions(project_id)
.setComputeServerIdForFile({
path: terminal_path,
compute_server_id,
confirm: false,
});
redux.getProjectActions(project_id).setComputeServerIdForFile({
path: terminal_path,
compute_server_id,
confirm: false,
});
}
}, [terminal_path]);

Expand Down Expand Up @@ -189,7 +186,7 @@ export function TerminalFlyout({

function init_terminal(): void {
if (!is_visible) return;
const node: any = ReactDOM.findDOMNode(terminalDOMRef.current);
const node = terminalDOMRef.current;
if (node == null) {
// happens, e.g., when terminals are disabled.
return;
Expand Down