Enable depsuasage plugin for go and javascript #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhisek
reviewed
Feb 28, 2025
core/language.go
Outdated
| // LanguageResolvers define the minimum contract for a language | ||
| // implementation to resolve language specific concerns | ||
| // such as imports, functions, etc. | ||
| type LanguageResolvers interface { | ||
| // ResolveImports returns a list of import statements | ||
| // identified from the parse tree | ||
| ResolveImports(tree ParseTree) ([]*ast.ImportNode, error) | ||
|
|
||
| // ResolveImportContents returns the contents of an import | ||
| ResolveImportContents(importNode *ast.ImportNode) (ImportContents, error) |
There was a problem hiding this comment.
Lets not introduce this because its not a core language concern. As discussion in #21 (comment)
Let us leave it on client code to decide how to deal with a language specific import name. For Go, the language specific import names include double quotes.
Signed-off-by: Omkar Phansopkar <[email protected]>
OmkarPh
force-pushed
the
feat/45-depsuasage-go-js
branch
from
f2d32c4 to
850a077
Compare
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
abhisek
reviewed
Mar 3, 2025
core/language.go
Outdated
| // ImportContents represents the contents of an import node | ||
| // It represents the ready to use content of import nodes which may | ||
| // exhibit different forms in different languages | ||
| type ImportContents struct { |
There was a problem hiding this comment.
I think we should avoid introducing this as a core language concern. It will introduce ambiguity wrt. ImportNode. If this is required, we can move this to helpers.
| } | ||
| } | ||
|
|
||
| func isIgnoredNode(node *sitter.Node, treeLanguage *core.Language, data *[]byte) bool { |
There was a problem hiding this comment.
Should have a test case for this because there are parsing and decisions involved.
Signed-off-by: Omkar Phansopkar <[email protected]>
abhisek
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-requisite for https://github.com/safedep/malysis/issues/42