Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/bclient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ export interface TralbumDetailsResponse {
price: number;
is_purchasable: boolean;
bandcamp_url?: string;
album_id?: number | null;
tracks?: TralbumTrack[];
}

Expand Down
37 changes: 29 additions & 8 deletions src/components/player/loader.ts
Original file line number Diff line number Diff line change
Expand Up @@ -222,12 +222,7 @@ export async function loadAlbumIntoDrawer(
log.info(`Loading album ${albumId} (${albumType}) into drawer`);

try {
const tralbumDetails = await getTralbumDetails(
albumId,
convertToApiType(albumType),
null,
createFetchFunction(enableFetchCaching)
);
const { tralbumDetails, startTrackId } = await fetchTralbumForDrawer(albumId, albumType, enableFetchCaching);

currentAlbumData = tralbumDetails;
selectAlbum(albumId);
Expand Down Expand Up @@ -258,8 +253,8 @@ export async function loadAlbumIntoDrawer(
}

attachTrackListHandlers();
loadTrack(0);
void loadTrackState(albumId);
loadTrack(startTrackIndex(tralbumDetails, startTrackId));
void loadTrackState(String(tralbumDetails.id));

log.info(`Album loaded: ${tralbumDetails.title} by ${tralbumDetails.tralbum_artist}`);
} catch (error) {
Expand All @@ -268,6 +263,32 @@ export async function loadAlbumIntoDrawer(
}
}

// A track that belongs to an album is shown as its whole album, starting on that track.
async function fetchTralbumForDrawer(
id: string,
type: string,
enableFetchCaching: boolean
): Promise<{ tralbumDetails: TralbumDetailsResponse; startTrackId?: number }> {
const fetchFn = createFetchFunction(enableFetchCaching);
const details = await getTralbumDetails(id, convertToApiType(type), null, fetchFn);
if (details.type !== 't' || !details.album_id) return { tralbumDetails: details };

try {
const album = await getTralbumDetails(details.album_id, 'a', null, fetchFn);
return { tralbumDetails: album, startTrackId: details.id };
} catch (error) {
log.warn(`Failed to load album ${details.album_id} for track ${id}, showing the track alone: ${error}`);
return { tralbumDetails: details };
}
}

function startTrackIndex(tralbumDetails: TralbumDetailsResponse, trackId?: number): number {
if (!trackId) return 0;

const index = tralbumDetails.tracks?.findIndex(track => track.track_id === trackId) ?? -1;
return Math.max(index, 0);
}

function currentTrack(): TralbumTrack | undefined {
return currentAlbumData?.tracks?.[currentTrackIndex];
}
Expand Down
45 changes: 45 additions & 0 deletions test/playerLoader.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,34 @@ vi.mock('../src/bclient', () => {
return {
getTralbumDetails: vi.fn(async (albumId: string | number) => {
const id = Number(albumId);

// Track 7772 is the second track of album 777; track 8000 is a standalone single
if (id === 7772 || id === 8000) {
return {
id,
type: 't',
album_id: id === 7772 ? 777 : null,
title: `Track ${id}`,
tralbum_artist: 'Test Artist',
is_purchasable: true,
price: 1.0,
currency: 'USD',
tracks: [playableTrack(id)]
};
}

if (id === 777) {
return {
id,
type: 'a',
title: 'Test Album 777',
tralbum_artist: 'Test Artist',
is_purchasable: true,
price: 10.0,
currency: 'USD',
tracks: [playableTrack(7771), playableTrack(7772), playableTrack(7773)]
};
}
// Album 456 has a playable first track and nothing playable after it
const tracks =
id === 456
Expand Down Expand Up @@ -280,6 +308,23 @@ describe('PlayerLoader - Main Player Logic', () => {
});
});

describe('Previewing a track', () => {
it('should show the whole album and start on that track', async () => {
await player.loadAlbumIntoDrawer('7772', 'track', false);

expect(player.getCurrentAlbumData()?.id).toBe(777);
expect(player.getCurrentTrackIndex()).toBe(1);
expect((document.querySelector('audio') as HTMLAudioElement).src).toContain('track7772.mp3');
});

it('should show a single on its own', async () => {
await player.loadAlbumIntoDrawer('8000', 'track', false);

expect(player.getCurrentAlbumData()?.id).toBe(8000);
expect(player.getCurrentTrackIndex()).toBe(0);
});
});

describe('Persistent audio element with state management', () => {
it('should create persistent audio element only once', async () => {
discography.updateDiscographyOrder();
Expand Down
Loading