Skip to content

Reset play state when a new album loads into the drawer #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IanHoar merged 2 commits into from
Oct 3, 2026
Merged

Reset play state when a new album loads into the drawer #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3287b00
Reset play state when a new album loads into the drawer
IanHoar Oct 1, 2026
c53fd7b
Test that a source swap resets the play button; drop the comment
IanHoar Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/components/player/loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,12 @@ function updateProgressBar(): void {
updateTimeDisplay(audioElement.currentTime, audioElement.duration);
}

function resetProgressBar(): void {
setStyle('.bes-progbar-fill', style => (style.width = '0%'));
setStyle('.bes-slider-container .bes-progbar-thumb', style => (style.left = '0%'));
setText('.bes-time-elapsed', formatTime(0));
}

export function isPlaybackClick(target: HTMLElement | null): boolean {
if (!target) return false;
return !target.closest('.bes-track-link, .bes-track-buy-col');
Expand Down Expand Up @@ -557,6 +563,10 @@ function bindAudioEvents(audio: HTMLAudioElement, playButton: HTMLElement): void
void reportPlay();
};
audio.onpause = reflectPlaying(false);
audio.onemptied = () => {
reflectPlaying(false)();
resetProgressBar();
};
audio.onended = () => step(forward, true);
audio.ontimeupdate = updateProgressBar;
}
Expand Down
7 changes: 7 additions & 0 deletions test/playerLoader.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,6 +849,13 @@ describe('PlayerLoader - Player Interactions', () => {

expect(document.querySelector('.bes-transport-play')?.classList.contains('playing')).toBe(false);
});

it('should unmark the play button when a new source replaces the playing one', () => {
audio.dispatchEvent(new Event('play'));
audio.dispatchEvent(new Event('emptied'));

expect(document.querySelector('.bes-transport-play')?.classList.contains('playing')).toBe(false);
});
});

describe('seeking by clicking the progress bar', () => {
Expand Down
Loading