Debuggable lattices #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regexident
force-pushed
the
debuggable-lattices
branch
from
2238213 to
b72b903
Compare
s-arash
reviewed
Dec 12, 2024
| @@ -3,7 +3,7 @@ use std::cmp::Ordering; | |||
| use super::{BoundedLattice, Lattice}; | |||
|
|
|||
| /// A flat `Lattice`: `Bottom` <= everything <= `Top`, and `Constant(x) == Constant(y)` iff `x == y` | |||
| #[derive(PartialEq, Eq, Clone, Copy, Debug, Hash)] | |||
| #[derive(PartialEq, Eq, Clone, Copy, Hash, Debug)] | |||
| fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result { self.0.fmt(f) } | ||
| } | ||
|
|
||
| impl<T: Debug> Display for OrdLattice<T> { |
There was a problem hiding this comment.
I don't think this impl is appropriate.
regexident
force-pushed
the
debuggable-lattices
branch
from
b72b903 to
2281d99
Compare
s-arash
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the lattice types don't impl
std::fmt::Debug, making it tedious to debug a program's state.