Skip to content

Update fastqc runner #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mgenereu wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update fastqc runner #106

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c427202
Update fastqc
mgenereu Oct 4, 2022
8ed7129
Return the exit code
mgenereu Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions fastqc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ if ($threads) {
unshift @java_args,"-Xmx${used_memory}m";
}
else {
unshift @java_args,'-Xmx${memory}m';
unshift @java_args,"-Xmx${memory}m";
}

if ($kmer_size) {
Expand Down Expand Up @@ -346,13 +346,8 @@ if (@files or $version or $help) {

#warn "Running 'exec $java_bin,@java_args, \"uk.ac.babraham.FastQC.FastQCApplication\", @files, CLASSPATH is $ENV{CLASSPATH}";


if ($java_bin ne 'java') {
system $java_bin,@java_args, "uk.ac.babraham.FastQC.FastQCApplication", @files;
}
else {
exec $java_bin,@java_args, "uk.ac.babraham.FastQC.FastQCApplication", @files;
Copy link
Author

@mgenereu mgenereu Oct 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exec is designed to be very blind to the success or failure of the underlying process. "Fire and forget." Please review this change as I haven't seen system and exec mixed like this before and didn't understand the underlying reason.

}
system $java_bin,@java_args, "uk.ac.babraham.FastQC.FastQCApplication", @files;
exit $? >> 8;

__DATA__

Expand Down