Increase weather icons 'other' icons scale #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] A lot of icons that do not represent a 'weather state' but rather a 'weather event' are in the 'weather state' scaling group which scales the icons waaaay down. This makes those icons almost unusable in stand alone use cases. [how] Put all the extra icons into a new scaling group that is defined before the weather state scaling group and thus takes precedence. Split the final scaling group to have some icons on individual scale. Fixes: #1708 Signed-off-by: Fini Jastrow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
A lot of icons that do not represent a 'weather state' but rather a 'weather event' are in the 'weather state' scaling group which scales the icons waaaay down. This makes those icons almost unusable in stand alone use cases.
[how]
Put all the extra icons into a new scaling group that is defined before the weather state scaling group and thus takes precedence.
Split the final scaling group to have some icons on individual scale.
Fixes: #1708
Requirements / Checklist
Issue number where discussion took place: #xxx
What does this Pull Request (PR) do?
Scale some icons bigger, that are currently in the same scale group as all the clouds and stuff and thus get very small.
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)
Top the weather set with the changed-in-size icons marked with blue background.
Bottom the set before this PR.
Icons in a Nerd Font Mono variant