Some mixin compatibility improvements#889
Closed
invokekitty wants to merge 8 commits into
Closed
Conversation
|
|
Contributor
|
For me this makes inspect mode in ponders unusable |
Collaborator
|
After talking with ryan it would be better if smaller prs to mixins were submitted with specific fixes for certain mods. It reduces the chance of a weird regression without any benefit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looked at some mixins and made a few changes to improve compatibility with other mods. This also allows lithium's efficient raycast implementation to be used on sub levels, as
BlockGetterMixinnow wraps the method instead of overwriting it.Besides this i replaced some Redirects that just wrap the original call with WrapOperation, ModifyArg or ModifyExpressionValue, and some Injects that cancel at RETURN with ModifyReturnValue.
Please tell me if i should change anything :3