Skip to content

Commit

Permalink
fix(api): made token & url attributes private
Browse files Browse the repository at this point in the history
  • Loading branch information
rwxd committed Mar 7, 2023
1 parent a4e34cf commit 4a1f16d
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions readwise/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ def __init__(
Args:
token: Readwise API token
'''
self.token = token
self.url = 'https://readwise.io/api/v2'
self._token = token
self._url = 'https://readwise.io/api/v2'

@property
def _session(self) -> requests.Session:
Expand All @@ -43,7 +43,7 @@ def _session(self) -> requests.Session:
session.headers.update(
{
'Accept': 'application/json',
'Authorization': f'Token {self.token}',
'Authorization': f'Token {self._token}',
}
)
return session
Expand Down Expand Up @@ -72,7 +72,7 @@ def _request(
Returns:
requests.Response
'''
url = self.url + endpoint
url = self._url + endpoint
logging.debug(f'Calling "{method}" on "{url}" with params: {params}')
response = self._session.request(method, url, params=params, json=data)
while response.status_code == 429:
Expand Down Expand Up @@ -133,7 +133,7 @@ def post(self, endpoint: str, data: dict = {}) -> requests.Response:
Returns:
requests.Response
'''
url = self.url + endpoint
url = self._url + endpoint
logging.debug(f'Posting "{url}" with data: {data}')
response = self._request('POST', endpoint, data=data)
response.raise_for_status()
Expand Down Expand Up @@ -337,8 +337,8 @@ def __init__(
Args:
token: Readwise Reader Connector token
'''
self.token = token
self.url = 'https://readwise.io/api/v3'
self._token = token
self._url = 'https://readwise.io/api/v3'

@property
def _session(self) -> requests.Session:
Expand All @@ -350,7 +350,7 @@ def _session(self) -> requests.Session:
session.headers.update(
{
'Accept': 'application/json',
'Authorization': f'Token {self.token}',
'Authorization': f'Token {self._token}',
}
)
return session
Expand All @@ -374,7 +374,7 @@ def _request(
Returns:
requests.Response
'''
url = self.url + endpoint
url = self._url + endpoint
logging.debug(f'Calling "{method}" on "{url}" with params: {params}')
response = self._session.request(method, url, params=params, json=data)
while response.status_code == 429:
Expand Down Expand Up @@ -410,7 +410,7 @@ def post(self, endpoint: str, data: dict = {}) -> requests.Response:
Returns:
requests.Response
'''
url = self.url + endpoint
url = self._url + endpoint
logging.debug(f'Posting "{url}" with data: {data}')
response = self._request('POST', endpoint, data=data)
response.raise_for_status()
Expand Down

0 comments on commit 4a1f16d

Please sign in to comment.