Add option to use mariadb command instead of mysql if installed #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently gotten deprecation warnings on systems running MariaDB that the
mysqlcommands are deprecated and that the MariaDB equivalent should be used instead.While this doesn't stop pynonymizer from working yet, I think it's a good idea to account for the deprecation.
I've prepared this quick fix for it, but I think that it'd be better in the long run to let the user to set/overwrite the path to the client binary with an env var or cli argument. I'd be willing to assist with implementing this if you want.