Skip to content

Bump to version 0.2.0 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2018
Merged

Bump to version 0.2.0 #31

merged 3 commits into from
Mar 6, 2018

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Mar 5, 2018

Fixes #30

r? @pepyakin @DrGoldfire: Whoever wants to rubber stamp this :)

@fitzgen fitzgen requested review from DrGoldfire and pepyakin March 5, 2018 18:32
Copy link
Collaborator

@DrGoldfire DrGoldfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fitzgen
Copy link
Member Author

fitzgen commented Mar 5, 2018

It looks like binaryen is failing:

+wasm-gc ../target/wasm32-unknown-unknown/release/wee_alloc_example.wasm ../target/wasm32-unknown-unknown/release/wee_alloc_example.gc.wasm
+wasm-opt -Oz ../target/wasm32-unknown-unknown/release/wee_alloc_example.gc.wasm -o ../target/wasm32-unknown-unknown/release/wee_alloc_example.gc.opt.wasm
[parse exception: index out of bounds: __rust_alloc]Fatal: error in parsing input

I don't know if this is a binaryen bug, or wasm-gc is creating bad input.

@pepyakin
Copy link
Member

pepyakin commented Mar 5, 2018

Complete guess, but maybe wasm gc mess up the name section? wasm2wat have —no-debug-names or similar option, i wonder if wasm opt have something like that

@fitzgen
Copy link
Member Author

fitzgen commented Mar 5, 2018

Working on the CI changes over in #32; will rebase on top of that and include that in the 0.2.0 release once the kinks are worked out.

@fitzgen fitzgen merged commit f0b61ca into master Mar 6, 2018
@fitzgen fitzgen deleted the bump-to-0.2.0 branch March 6, 2018 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants