Skip to content

😥 [DO NOT MERGE] Correct default features key. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

psbrandt
Copy link

@psbrandt psbrandt commented Oct 8, 2018

As a Rust newbie, this had me scratching my head for a good long while.

As a Rust newbie, this had me scratching my head for a good long while.
@psbrandt
Copy link
Author

psbrandt commented Oct 8, 2018

This change brings to light another problem: rust-lang/rust#44113 (global_allocator cannot be used in submodules). To fix this in my project I just dumped the cfg_if macro in lib.rs, but I'm not sure what you want for the template.

p.s. I ran into this while working through the Game of Life tutorial.

@psbrandt psbrandt changed the title 😥 Correct default features key. 😥 [DO NOT MERGE] Correct default features key. Oct 8, 2018
@fitzgen
Copy link
Member

fitzgen commented Oct 9, 2018

Thanks for sending a PR! I was just alerted to this the other day, and hadn't made a fix yet. I'll do a PR for everything in a second :)

@psbrandt
Copy link
Author

psbrandt commented Oct 9, 2018

No problem. Sorry I didn't implement the complete fix.

@fitzgen fitzgen mentioned this pull request Oct 9, 2018
@fitzgen
Copy link
Member

fitzgen commented Oct 9, 2018

Closing in favor or #25 -- thanks again!

@fitzgen fitzgen closed this Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants