fix: making rustsbi-qemu completely runnable again. #66
+97
−71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After rust-lang/rust#128651 merged in nightly toolchain,
asm!
macro is not allowed in naked functions.Also, I discovered unhandled lint error including
creating a mutable reference to mutable static
andcreating a shared reference to mutable static
, which is making the program completely not runnable.What's more, I discovered more
asm!
s in other dependencies, I upgraded version but nothing helped.Therefore, this pull request aims to update rustsbi-qemu to adapt to current rust versions.
I also forked and made some changes in other dependency repositories, you need to accept them and update their versions in
cargo.toml
in order to successfully run the project.Changes:
#![feature(naked_functions, asm_const)]
as they are no longer needed.naked_asm!
macro to comply with new naked function requirements.options(noreturn)
, which is not allowed innaked_asm!
.creating a mutable/shared reference to mutable static
in multiple files.