Per-platform candidates, multiple directories #41
Conversation
| target_os = "netbsd", | ||
| target_os = "aix" | ||
| )))] | ||
| const CERTIFICATE_DIRS: &[&str] = &["/etc/ssl/certs"]; |
There was a problem hiding this comment.
Should we have an empty CERTIFICATE_DIRS for darwin and windows? (Same for CERTIFICATE_FILE_NAMES.)
|
I will happily give you feedback in the next couple of days |
ctz
left a comment
ctz
left a comment
There was a problem hiding this comment.
LGTM. I would be tempted to take a cfg-if dependency for some of the conditionals.
|
I'll go ahead and merge this now to allow downstream work to progress, happy to take more feedback and iterate. |
|
I didn't even get a chance to review 😕 |
That's why I said:
You can still review and I will make changes in response to your feedback. |
Alright, will do next week |
|
@cpu @michael-o any feedback? |
I have allocated some time for it this Friday. Will let you know in two days. |
|
@djc Completed testing, will raise a new PR to discuss further. |
This combines the data from the Go std library with what we had in this project previously (reviewing all PRs).
@michael-o please check if this resolves your issues on BSD.