add webrtc stream

[lichon]

This pull request introduces WebRTC support to the project, allowing connections to be established using the WebRTC protocol in addition to existing TCP and WebSocket options. The main changes include adding new dependencies, implementing a WebRTC stream wrapper, updating the connection logic to detect and handle WebRTC endpoints

These changes collectively add WebRTC support as a first-class transport option, expanding the range of protocols supported by the project and providing a foundation for further development and testing of WebRTC-based features.

Any idea?

[lichon]

@fufesou any idea?

[rustdesk]

Please make this as an optional feature.

[Copilot]

Pull Request Overview

This pull request adds WebRTC transport support to the project, enabling peer-to-peer connections using the WebRTC protocol alongside existing TCP and WebSocket options. The implementation includes endpoint detection, connection establishment via SDP offer/answer exchange, and a stream wrapper that integrates with the existing Stream enum.

Key Changes:

• Added webrtc crate dependency (v0.14.0) and implemented a WebRTCStream wrapper with send/receive methods
• Extended the Stream enum and connection logic to detect and handle webrtc:// prefixed endpoints
• Included an example demonstrating WebRTC data channel usage

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
src/webrtc.rs	New WebRTC stream implementation with connection management, SDP handling, and data channel I/O operations
src/stream.rs	Extended Stream enum to include WebRTC variant and added corresponding method dispatching
src/socket_client.rs	Added WebRTC endpoint detection and connection initiation in the TCP connection flow
src/lib.rs	Exposed the new webrtc module as a public API
examples/webrtc.rs	Example code demonstrating WebRTC peer connection setup and data channel communication
Cargo.toml	Added webrtc dependency and dev dependencies for the example

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[lichon]

@rustdesk

Please make this as an optional feature.

Like which kind of optional, cargo build features?

[rustdesk]

YES

[rustdesk]

Also, please write a working example for this webRTC stream.

[lichon]

I don't think it will affect other well-functioning code. It will only be activated when encountering specific webrtc:// connection endpoints.
Still need to be optional feature?
Or you just dont want to link too much unused libs?

[lichon]

Also, please write a working example for this webRTC stream.

Yea, I would try it, since we need a signal server here, it's not a simple example

[rustdesk]

You can do a simple mock signal server.

[rustdesk]

I don't think it will affect other well-functioning code. It will only be activated when encountering specific webrtc:// connection endpoints.

It will increase the binary size (disk space) and build time (cpu usage) if some one do not need this feature. webrtc is not a small crate.

you just dont want to link too much unused libs?

Yes, this is another reason.

[rustdesk]

Remove all unwrap/expect. We do not allow those causes crash. All exception must be handled rather than crash directly.

Only mutex unwrap is allowed.

[lichon]

example updated

[rustdesk]

please put webrtc_dummy in examples/webrtc.rs

[lichon]

please put webrtc_dummy in examples/webrtc.rs

we need this in stream.rs when webrtc feature disabled

[rustdesk]

we need this in stream.rs when webrtc feature disabled

Why? Can not use #[cfg(feature = "webrtc")]? I suggest you ask chatgpt.

[Copilot]

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 21 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[lichon]

fixed all in next patch

[Copilot]

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 21 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[lichon]

Update here, I build a rustdesk web terminal, both websocket and webrtc works fine with this patch

[rustdesk]

web terminal

Code?

[lichon]

rustdesk-web-ts

[rustdesk]

What TURN server do you use?

[lichon]

It's webrtc P2P

[lichon]

If you need a relay, just disable webrtc, websocket relay still works

[rustdesk]

have you ever tested TURN?

[lichon]

500MB free plan here: metered.ca
force relay works, test from example