This repository was archived by the owner on Oct 30, 2019. It is now read-only.
Update for futures v0.3.0-alpha.15 #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nemo157
force-pushed
the
futures-alpha.15
branch
from
a0503eb to
1dee88e
Compare
Replace (most) usage of FutureObj with BoxFuture and use BoxFuture to simplify some function signatures. Enable the async-await feature for the tests.
Nemo157
force-pushed
the
futures-alpha.15
branch
from
1dee88e to
2e6290c
Compare
yoshuawuyts
approved these changes
Apr 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace (most) usage of FutureObj with BoxFuture and use BoxFuture to
simplify some function signatures.
Enable the async-await feature for the tests.
Description
Motivation and Context
Fixes #6.
Types of changes
The only breaking change is changing
Runtime::spawn_objintoRuntime::spawn_boxed, the other function signature changes are identical after type alias expansion.