Refactor usage of CFRunLoopObserver
#4349
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
DS - appkit
madsmtm
force-pushed
the
madsmtm/better-observers
branch
2 times, most recently
from
32a9baa to
e341ecd
Compare
Added a common interface that: - Uses closures instead of static functions. This should allow easier refactoring in the future. - Returns a handle which is invalidated on `Drop`. This should avoid situations where the event loop has exited, but an observer is still called because the user spawned the application later on. - Is properly main-thread safe. This interface is placed in winit-common, to allow using it in both winit-appkit and winit-uikit.
madsmtm
force-pushed
the
madsmtm/better-observers
branch
from
e341ecd to
651c3f4
Compare
|
Is there any chance that this fixes #1418 ? |
Member
Author
|
No, but #4155 might. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a common interface that:
Drop. This should avoid situations where the event loop has exited, but an observer is still called because the user spawned the application later on.This interface is placed in
winit-common, to allow using it in bothwinit-appkitandwinit-uikit.changelogmodule if knowledge of this change could be valuable to users