Update to latest Rust #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Are the examples building? |
|
Looks like they haven't been updated since I also fixed them to work on systems that don't support OpenGL 3.2. Hopefully I did it in a way which still works on OSX. |
|
Thanks! Could the OpenGL change be part of a separate PR? I'd like to talk about it first before we merge it. |
|
Done. (Although I can't test if the examples work) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
~""to"".to_owned()I tried replacing some of them with
&strs but it seems that rust-lang/rust#11869 is still causing trouble.