add request_interrupt_window handling#193
Open
QuarkContainer wants to merge 2 commits intorust-vmm:mainfrom
Open
add request_interrupt_window handling#193QuarkContainer wants to merge 2 commits intorust-vmm:mainfrom
QuarkContainer wants to merge 2 commits intorust-vmm:mainfrom
Conversation
QuarkContainer
requested review from
acatangiu,
alxiord,
andreeaflorescu,
lauralt and
sameo
as code owners
lauralt
reviewed
Feb 2, 2022
Collaborator
lauralt
left a comment
lauralt
left a comment
There was a problem hiding this comment.
Thanks for the contribution. Can you also please sign off your commit (git commit -s --amend)?
Comment on lines
+1437
to
+1438
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
I think these are unintentional.
| } | ||
|
|
||
| /// Sets the `request_interrupt_window` flag on the `kvm_run` struct associated with this vCPU to `val`. | ||
| pub fn set_kvm_request_interrupt_window(&self, val: u8) { |
Collaborator
There was a problem hiding this comment.
Can you also add a test for this, it can be similar to the one for set_kvm_immediate_exit?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.