-
Notifications
You must be signed in to change notification settings - Fork 384
Refactor repository structure to include translations #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
All checks run through, I still need to test for the output and usability. |
Ready to review, we need a few changes after merge:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks.
Please go back to 3 ` before merging :)
4 is weird D:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh, now I get it, it was because there were 3 inside 🤯 Ok, then I have no problems with 4
in these cases 👍
…blem" This reverts commit 8143a55.
@marcoieni Reverted the change I made and updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Fixes #345
Output can be seen here: https://simonsan.github.io/patterns
Resources:
Todo: