Skip to content

Refactor repository structure to include translations #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Apr 7, 2023

Conversation

simonsan
Copy link
Collaborator

@simonsan simonsan commented Apr 5, 2023

Fixes #345

Output can be seen here: https://simonsan.github.io/patterns

Resources:

Todo:

  • Elaborate on how to add a translation
  • check if initial rendered html state without any translation is the same as our normal book page (besides maybe the top right globe containing only English)

@simonsan simonsan added M-maintenance Meta: Maintenance A-translation Area: Everything regarding translations labels Apr 5, 2023
@simonsan simonsan closed this Apr 5, 2023
@simonsan simonsan reopened this Apr 5, 2023
@simonsan simonsan mentioned this pull request Apr 5, 2023
@simonsan simonsan marked this pull request as ready for review April 5, 2023 15:15
@simonsan
Copy link
Collaborator Author

simonsan commented Apr 5, 2023

All checks run through, I still need to test for the output and usability.

@simonsan simonsan marked this pull request as draft April 6, 2023 20:38
@simonsan simonsan marked this pull request as ready for review April 7, 2023 12:44
@simonsan simonsan requested a review from marcoieni April 7, 2023 12:44
@simonsan
Copy link
Collaborator Author

simonsan commented Apr 7, 2023

Ready to review, we need a few changes after merge:

@simonsan
Copy link
Collaborator Author

simonsan commented Apr 7, 2023

These actions have been removed and replaced:

2023-04-07 16_02_39-Refactor repository structure to include translations by simonsan · Pull Request

Markdownlint, has been replaced with dprint as dprint can also format code within md files.

marcoieni
marcoieni previously approved these changes Apr 7, 2023
Copy link
Collaborator

@marcoieni marcoieni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.
Please go back to 3 ` before merging :)
4 is weird D:

@simonsan simonsan requested a review from marcoieni April 7, 2023 19:51
marcoieni
marcoieni previously approved these changes Apr 7, 2023
Copy link
Collaborator

@marcoieni marcoieni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh, now I get it, it was because there were 3 inside 🤯 Ok, then I have no problems with 4 in these cases 👍

@simonsan
Copy link
Collaborator Author

simonsan commented Apr 7, 2023

@marcoieni Reverted the change I made and updated messages.pot :D Need to review again :/

@simonsan simonsan requested a review from marcoieni April 7, 2023 20:11
@simonsan simonsan enabled auto-merge (squash) April 7, 2023 20:12
Copy link
Collaborator

@marcoieni marcoieni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@simonsan simonsan merged commit c30a6eb into rust-unofficial:main Apr 7, 2023
@simonsan simonsan deleted the translations branch April 7, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-translation Area: Everything regarding translations M-maintenance Meta: Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translations
2 participants