-
Notifications
You must be signed in to change notification settings - Fork 383
chore: update rust edition to 2021 #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I would probably adapt all the pages + examples first to the Meaning, we should change it exactly like you did but also check which idioms, patterns are still needed or useful. Setting |
I think that nothing changes with our content if the reader has Instead, by merging this PR now, we make sure that the rust examples of this book can be compiled with rust edition 2021 👍 Also, does it makes sense to release the OT: it was around this period we started maintaining this project together. So happy "anniversary"! Thanks for everything you have done for this project and happy holidays 🎄 |
Happy anniversary as well! :) I'm a bit off the grid the next days, so will answer next week, when I had time to think about it properly! 😅 |
With the EDIT: related issue #356 |
Pull request was converted to draft
No description provided.