Skip to content

chore: update rust edition to 2021 #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 23, 2023
Merged

chore: update rust edition to 2021 #332

merged 4 commits into from
Dec 23, 2023

Conversation

marcoieni
Copy link
Collaborator

No description provided.

@marcoieni marcoieni enabled auto-merge (squash) December 18, 2022 18:11
@simonsan simonsan added the F-2021 Feature: 2021 Edition specific label Dec 22, 2022
@simonsan
Copy link
Collaborator

I would probably adapt all the pages + examples first to the 2021 edition before setting this?

Meaning, we should change it exactly like you did but also check which idioms, patterns are still needed or useful. Setting 2021 edition in the book should also mark our milestone of being patterns 2021 edition IMHO.

@simonsan simonsan added this to the 2021 Edition milestone Dec 22, 2022
@marcoieni
Copy link
Collaborator Author

also check which idioms, patterns are still needed or useful.

I think that nothing changes with our content if the reader has 2018 or 2021 as the edition field of their crate.
If you are suggesting reviewing all the book...this is going to take a lot of time, which I would love to have, but I don't :/

Instead, by merging this PR now, we make sure that the rust examples of this book can be compiled with rust edition 2021 👍

Also, does it makes sense to release the patterns 2021 edition at the end of 2022? 😛

OT: it was around this period we started maintaining this project together. So happy "anniversary"! Thanks for everything you have done for this project and happy holidays 🎄

@simonsan
Copy link
Collaborator

also check which idioms, patterns are still needed or useful.

I think that nothing changes with our content if the reader has 2018 or 2021 as the edition field of their crate. If you are suggesting reviewing all the book...this is going to take a lot of time, which I would love to have, but I don't :/

Instead, by merging this PR now, we make sure that the rust examples of this book can be compiled with rust edition 2021 👍

Also, does it makes sense to release the patterns 2021 edition at the end of 2022? 😛

OT: it was around this period we started maintaining this project together. So happy "anniversary"! Thanks for everything you have done for this project and happy holidays 🎄

Happy anniversary as well! :) I'm a bit off the grid the next days, so will answer next week, when I had time to think about it properly! 😅

@simonsan
Copy link
Collaborator

simonsan commented Apr 6, 2023

With the translations refactor coming in, I want to discuss a change that is also related to this PR. Will open an issue.

EDIT: related issue #356

@simonsan simonsan marked this pull request as draft April 7, 2023 20:31
auto-merge was automatically disabled April 7, 2023 20:31

Pull request was converted to draft

@simonsan simonsan marked this pull request as ready for review December 23, 2023 04:29
@simonsan simonsan merged commit e4e6ac2 into main Dec 23, 2023
@simonsan simonsan deleted the edition-2021 branch December 23, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-2021 Feature: 2021 Edition specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants